Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: Removed unused code #25513

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

peteski22
Copy link

@peteski22 peteski22 commented Feb 20, 2024

EntryFormatterWriter and the Writer interface are no longer required.

They were maintained during 1.15.x as we allowed customers a way to revert to non-eventlogger audit behaviour, but this flag has been removed.

@peteski22 peteski22 added core/audit pr/no-changelog hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Feb 20, 2024
@peteski22 peteski22 added this to the 1.16.0-rc2 milestone Feb 20, 2024
@peteski22 peteski22 enabled auto-merge (squash) February 20, 2024 10:14
Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubawi
Copy link
Contributor

kubawi commented Feb 20, 2024

Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@peteski22 peteski22 merged commit 290df86 into main Feb 20, 2024
83 checks passed
@peteski22 peteski22 deleted the peteski22/VAULT-23334/refactor-remove-unused branch February 20, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/audit hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants