Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Make empty state links consistent #25209

Merged
merged 4 commits into from
Feb 3, 2024
Merged

UI: Make empty state links consistent #25209

merged 4 commits into from
Feb 3, 2024

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Feb 2, 2024 •
edited
Loading

This PR aims to make our EmptyState views more consistent by:

  1. removing redundant actions (i.e. Create secret when the toolbar already has a + Create secret action)
  2. remove multiple actions (exceptions to this are when an error provides a doc link and action to Go back
  3. Update all yielded actions to Hds::Link::Standalone for styling consistency

before/after screenshots 📸

Screenshot 2024-02-02 at 2 38 54 PM Screenshot 2024-02-02 at 2 39 27 PM Screenshot 2024-02-02 at 2 43 53 PM

enterprise tests ✅

Screenshot 2024-02-02 at 4 55 23 PM

@hellobontempo hellobontempo added this to the 1.16.0-rc1 milestone Feb 2, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Build Results:
All builds succeeded! ✅

Monkeychip
Monkeychip approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 nice work on this. It's going to look a lot better. It looks like you already have, but just to confirm, run enterprise tests locally.

@hellobontempo hellobontempo merged commit 79ed357 into main Feb 3, 2024
72 checks passed
@hellobontempo hellobontempo deleted the ui/VAULT-23370/single-action-empty-states branch February 3, 2024 00:56
@hellobontempo hellobontempo mentioned this pull request Feb 5, 2024
Merged
Monkeychip pushed a commit that referenced this pull request Feb 5, 2024
@hellobontempo @Monkeychip
UI: Make empty state links consistent (#25209)
4f042f1 
* round one of updating empty state actions

* second round of empty states

* update tests

* add changelog
Monkeychip pushed a commit that referenced this pull request Feb 7, 2024
@hellobontempo @Monkeychip
UI: Make empty state links consistent (#25209)
e4d6759 
* round one of updating empty state actions

* second round of empty states

* update tests

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.16.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@hellobontempo @Monkeychip