Support setting plugin TMPDIR in config as well as env #24978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
tvoran
approved these changes
Jan 23, 2024
Comment on lines
+141
to
+149
| type PluginCatalogInput struct { | ||
| Logger log.Logger | ||
| BuiltinRegistry BuiltinRegistry | ||
| CatalogView logical.Storage | ||
| PluginDirectory string | ||
| Tmpdir string | ||
| EnableMlock bool | ||
| PluginRuntimeCatalog *PluginRuntimeCatalog | ||
| } |
Thanks for the reminder, added one in the latest commit. |
|
Thanks! |
Monkeychip
pushed a commit
that referenced
this pull request
Jan 30, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run containerized plugins under systemd with PrivateTmp=true, users need control over the tmpdir used for Unix sockets (see #23215). Previously we supported this solely with a
VAULT_PLUGIN_TMPDIRenv var, and this PR adds the option to the config file as well. As with other settings supported in config and env, the env takes precedence.