Skip to content

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Oct 17, 2023

This PR adds a warning when whitespace is detected in a key of a KV engine secret.

image
image
image

Closes #6714

@zofskeez zofskeez added this to the 1.15.1 milestone Oct 17, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 17, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test!

@zofskeez zofskeez merged commit 43afcd7 into main Oct 17, 2023
@zofskeez zofskeez deleted the ui/VAULT-20228/kv-key-whitespace branch October 17, 2023 21:36
@zofskeez zofskeez modified the milestones: 1.15.1, 1.16.0-rc1 Oct 20, 2023
zofskeez added a commit that referenced this pull request Oct 20, 2023
* adds warning for kv key that contains whitespace

* adds changelog entry
zofskeez added a commit that referenced this pull request Oct 20, 2023
* adds warning for kv key that contains whitespace

* adds changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI does not trim leading/trailing whitespaces in a secret's key
2 participants