Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Disable Replication Status Endpoints in Listener Configuration #23547

Merged
merged 21 commits into from
Oct 11, 2023
Merged

Add Ability to Disable Replication Status Endpoints in Listener Configuration #23547

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
83ae451
CI: Pre-emptively delete logs dir after cache restore in test-collect…
kubawi Oct 11, 2023
f144d1b
Fix OktaNumberChallenge (#23565)
Monkeychip Oct 11, 2023
163c03f
exclude changelog in verifying doc/ui PRs (#23601)
hghaf099 Oct 11, 2023
88fb88e
Audit: eventlogger sink node reopen on SIGHUP (#23598)
Oct 11, 2023
bc64648
Capture errors emitted from all nodes during proccessing of audit pip…
Oct 11, 2023
525bf2f
Update security-scan.yml
mcollao-hc Oct 11, 2023
813c786
Listeners: Redaction only for TCP (#23592)
Oct 11, 2023
2f8e59c
fix panic when unlocking unlocked user (#23611)
davidadeleon Oct 11, 2023
30f19b3
VAULT-18307: update rotation period for aws static roles on update (#…
kpcraig Oct 11, 2023
88183ab
add disable_replication_status_endpoints tcp listener config parameter
Oct 3, 2023
1111cbd
add wrapping handler for disabled replication status endpoints setting
Oct 5, 2023
143d47c
adapt disable_replication_status_endpoints configuration parsing code…
Oct 5, 2023
ca60b22
refactor configuration parsing code to facilitate testing
Oct 6, 2023
294d962
fix a panic when parsing configuration
Oct 6, 2023
47c3f5b
update refactored configuration parsing code
Oct 6, 2023
a33a93c
fix merge corruption
Oct 6, 2023
2b9879b
add changelog file
Oct 10, 2023
2319e88
document new TCP listener configuration parameter
Oct 10, 2023
c420c66
make sure disable_replication_status_endpoints only has effect on TCP…
Oct 10, 2023
a9feb41
use active voice for explanation of disable_replication_status_endpoints
Oct 10, 2023
3f5f03c
fix minor merge issue
Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
document new TCP listener configuration parameter
  • Loading branch information
Marc Boudreau committed Oct 11, 2023
commit 2319e884a22a93e6dce1ab401b89db5b99a9019c
4 changes: 4 additions & 0 deletions website/content/docs/configuration/listener/tcp.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,10 @@ default value in the `"/sys/config/ui"` [API endpoint](/vault/api-docs/system/co
there is no X-Forwarded-For header or it is empty, the client address will be
used as-is, rather than the client connection rejected.

- `disable_replication_status_endpoints` `(bool: false)` - If set true, the
replication status endpoints will be disabled for requests sent to this
listener.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `disable_replication_status_endpoints` `(bool: false)` - If set true, the
replication status endpoints will be disabled for requests sent to this
listener.
- `disable_replication_status_endpoints` `(bool: false)` - Disables replication
status endpoints for the configured listener when set to `true`.

Style correction: write in active voice, avoid "this" as a pronoun

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this reads much better.


### `telemetry` parameters

- `unauthenticated_metrics_access` `(bool: false)` - If set to true, allows
Expand Down