Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for double slash in LIST endpoint #23446

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Oct 2, 2023

This UI only regression bug was potentially introduced by this PR.

The reproduction steps of how the bug was reported:

  1. on a binary
  2. Create a namespace
  3. Within the namespace mount the auth method userpass.
  4. Create a user userpass and navigate to the list view. No users would show and there was a 301 followed by a 404 error on the network request on this LIST endpoint. if you look closely, you'll see a double forward slash.
    http://localhost:4200/v1/auth/userpass/users//?list=true

This fix cleans out the double forward slash and resolves the issue. The sanitizePath method removes any whitespace and trailing and leading slashes.

TODO:

  • test to make sure doesn't break anything ✅
  • run enterprise tests locally. ✅

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 2, 2023
@Monkeychip Monkeychip added this to the 1.15.1 milestone Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

CI Results:
All Go tests succeeded! ✅

@Monkeychip Monkeychip marked this pull request as ready for review October 2, 2023 19:00
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job tracking this down! 🕵️

@Monkeychip Monkeychip merged commit 32059ab into main Oct 2, 2023
160 of 161 checks passed
@Monkeychip Monkeychip deleted the ui/VAULT-20546/regression-bug branch October 2, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants