Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets-Sync/vault-18673-documentation #23189

Merged
merged 39 commits into from
Sep 27, 2023
Merged

Conversation

maxcoulombe
Copy link
Contributor

@maxcoulombe maxcoulombe commented Sep 20, 2023

Working branch to gather all the documentation contributions.

🔍 Deploy preivew

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 20, 2023
@maxcoulombe maxcoulombe added this to the 1.15.0 milestone Sep 20, 2023
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

page_title: Secrets Sync
description: Secrets sync allows you to safely sync Vault-managed secrets with external destinations.
---

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add an Enterprise alert here. It will automatically render with the Vault logo.

I think it's also common on the top of the API docs page for ent features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup done!

@maxcoulombe maxcoulombe marked this pull request as ready for review September 26, 2023 22:24
@maxcoulombe maxcoulombe requested a review from a team as a code owner September 26, 2023 22:24
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Member

@robmonte robmonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants