Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: HDS adoption replace <CopyButton> component #22333

Merged
merged 26 commits into from
Sep 15, 2023
Merged

UI: HDS adoption replace <CopyButton> component #22333

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
86ff82c
Part 1: Upgrade HDS to 2.9.0 (#22311)
malinac02 Aug 15, 2023
1ae69ad
Merge branch 'main' into ui/VAULT-18829/hds-adoption-replace-CopyButton
malinac02 Aug 24, 2023
228c6a2
UI: HDS adoption replace <CopyButton> part 2 (#22356)
malinac02 Aug 29, 2023
499e047
Merge branch 'main' into ui/VAULT-18829/hds-adoption-replace-CopyButton
malinac02 Sep 5, 2023
0045a29
UI: HDS adoption replace <CopyButton> part 3 (#22614)
malinac02 Sep 6, 2023
4f8dc36
Merge branch 'main' into ui/VAULT-18829/hds-adoption-replace-CopyButton
malinac02 Sep 8, 2023
662c631
UI: HDS adoption replace <CopyButton> part 4 (#22749)
malinac02 Sep 8, 2023
d596f80
Merge branch 'main' into ui/VAULT-18829/hds-adoption-replace-CopyButton
hellobontempo Sep 13, 2023
ed2d5f3
update code snippet copy button
hellobontempo Sep 13, 2023
a27881c
UI: HDS adoption replace <CopyButton> part 5: Cleanup (#22884)
malinac02 Sep 13, 2023
5329b58
rename class to transparent background
hellobontempo Sep 14, 2023
0379783
remove unused test selectors
hellobontempo Sep 14, 2023
7a65c27
replace transit actions with Copy::Snippet
hellobontempo Sep 14, 2023
0a7bfa8
replace transfrom code blocks with code snippet component
hellobontempo Sep 14, 2023
effb2a0
revert extra css fiddling
hellobontempo Sep 14, 2023
7f58d4b
misc cleanup, unused action
hellobontempo Sep 14, 2023
a1156f9
remove copy & close buttons from transit modals
hellobontempo Sep 14, 2023
2bf3524
remove is- from class naming
hellobontempo Sep 14, 2023
abeb6be
remove hds-copy-button class
hellobontempo Sep 14, 2023
2f09675
add other grey class
hellobontempo Sep 14, 2023
230d1d6
more small cleanup
hellobontempo Sep 14, 2023
4eaf13a
add -top to margin
hellobontempo Sep 15, 2023
948b9fa
add changelog
hellobontempo Sep 15, 2023
6468f7b
Merge branch 'main' into ui/VAULT-18829/hds-adoption-replace-CopyButton
hellobontempo Sep 15, 2023
790ef37
Merge branch 'main' into ui/VAULT-18829/hds-adoption-replace-CopyButton
hellobontempo Sep 15, 2023
961fbf1
Merge branch 'main' into ui/VAULT-18829/hds-adoption-replace-CopyButton
hellobontempo Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused test selectors
  • Loading branch information
@hellobontempo
hellobontempo committed Sep 14, 2023
commit 037978386ec07395206ee9f987d502213fbd23db
17 changes: 2 additions & 15 deletions ui/app/templates/components/transit-key-action/datakey.hbs
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consulted design and opted to remove blue copy buttons as they were redundant and anti-pattern

before / after

Screenshot 2023-09-14 at 2 52 46 PM

all of the /transit-key-action files have similar before/after views

Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@
@isIconOnly={{true}}
@textToCopy={{@plaintext}}
class="hds-copy-button transparent-background"
data-test-button="modal-copy"
/>
</div>
<p class="help has-bottom-margin-m">Plaintext is base64 encoded</p>
Expand All @@ -100,22 +99,11 @@
@isIconOnly={{true}}
@textToCopy={{@ciphertext}}
class="hds-copy-button transparent-background"
data-test-button="modal-copy"
/>
</div>
<div class="is-flex-align-baseline has-gap-xxs">
<Hds::Copy::Button
@text="Copy Plaintext"
@textToCopy={{@plaintext}}
class="hds-copy-button is-primary"
data-test-button="modal-copy-close"
/>
<Hds::Copy::Button
@text="Copy Ciphertext"
@textToCopy={{@ciphertext}}
class="hds-copy-button is-primary"
data-test-button="modal-copy-close"
/>
<Hds::Copy::Button @text="Copy Plaintext" @textToCopy={{@plaintext}} class="hds-copy-button is-primary" />
<Hds::Copy::Button @text="Copy Ciphertext" @textToCopy={{@ciphertext}} class="hds-copy-button is-primary" />
<button type="submit" class="button is-secondary" onclick={{action (mut @isModalActive) false}}>Close</button>
</div>
{{else}}
Expand All @@ -128,7 +116,6 @@
@isIconOnly={{true}}
@textToCopy={{@ciphertext}}
class="hds-copy-button transparent-background"
data-test-button="modal-copy"
/>
</div>
<Hds::Copy::Button
Expand Down
2 changes: 0 additions & 2 deletions ui/app/templates/components/transit-key-action/decrypt.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
@isIconOnly={{true}}
@textToCopy={{@plaintext}}
class="hds-copy-button transparent-background"
data-test-button="modal-copy"
/>
</div>
<p class="help">Plaintext is base64 encoded</p>
Expand All @@ -79,7 +78,6 @@
@text="Copy & Close"
@textToCopy={{@plaintext}}
class="hds-copy-button is-primary"
data-test-button="modal-copy-close"
{{on "click" (fn @toggleModal "Plaintext copied!")}}
/>
</footer>
Expand Down
2 changes: 0 additions & 2 deletions ui/app/templates/components/transit-key-action/encrypt.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
@isIconOnly={{true}}
@textToCopy={{@ciphertext}}
class="hds-copy-button transparent-background"
data-test-button="modal-copy"
/>
</div>
</div>
Expand All @@ -96,7 +95,6 @@
@text="Copy & Close"
@textToCopy={{@ciphertext}}
class="hds-copy-button is-primary"
data-test-button="modal-copy-close"
{{on "click" (fn @toggleModal "Ciphertext copied!")}}
/>
</footer>
Expand Down
2 changes: 0 additions & 2 deletions ui/app/templates/components/transit-key-action/export.hbs
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-14 at 2 55 19 PM

Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
@isIconOnly={{true}}
@textToCopy={{if this.wrapTTL @wrappedToken (stringify @keys)}}
class="hds-copy-button transparent-background"
data-test-button="modal-copy"
/>
</div>
</div>
Expand All @@ -89,7 +88,6 @@
@text="Copy & Close"
@textToCopy={{if this.wrapTTL @wrappedToken (stringify @keys)}}
class="hds-copy-button is-primary"
data-test-button="modal-copy-close"
{{on "click" (fn @toggleModal "Token copied!")}}
/>
</footer>
Expand Down
2 changes: 0 additions & 2 deletions ui/app/templates/components/transit-key-action/hmac.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
@isIconOnly={{true}}
@textToCopy={{@hmac}}
class="hds-copy-button transparent-background"
data-test-button="modal-copy"
/>
</div>
</div>
Expand All @@ -73,7 +72,6 @@
@text="Copy & Close"
@textToCopy={{@hmac}}
class="hds-copy-button is-primary"
data-test-button="modal-copy-close"
{{on "click" (fn @toggleModal "HMAC copied!")}}
/>
</footer>
Expand Down
2 changes: 0 additions & 2 deletions ui/app/templates/components/transit-key-action/rewrap.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
@isIconOnly={{true}}
@textToCopy={{@ciphertext}}
class="hds-copy-button transparent-background"
data-test-button="modal-copy"
/>
</div>
</div>
Expand All @@ -85,7 +84,6 @@
@text="Copy & Close"
@textToCopy={{@ciphertext}}
class="hds-copy-button is-primary"
data-test-button="modal-copy-close"
{{on "click" (fn @toggleModal "Ciphertext copied!")}}
/>
</footer>
Expand Down
2 changes: 0 additions & 2 deletions ui/app/templates/components/transit-key-action/sign.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@
@isIconOnly={{true}}
@textToCopy={{@signature}}
class="hds-copy-button transparent-background"
data-test-button="modal-copy"
/>
</div>
</div>
Expand All @@ -147,7 +146,6 @@
@text="Copy & Close"
@textToCopy={{@signature}}
class="hds-copy-button is-primary"
data-test-button="modal-copy-close"
{{on "click" (fn @toggleModal "Signature copied!")}}
/>
</footer>
Expand Down
1 change: 0 additions & 1 deletion ui/lib/replication/addon/templates/mode/secondaries/add.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
@text="Copy & Close"
@textToCopy={{this.token}}
class="hds-copy-button is-primary"
data-test-button="modal-copy-close"
{{on "click" (action "copyClose" "Token copied!")}}
/>
</footer>
Expand Down