Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional automatic default issuer selection #17824

Merged
merged 7 commits into from
Nov 8, 2022
Merged

Optional automatic default issuer selection #17824

merged 7 commits into from
Nov 8, 2022

Commits on Nov 4, 2022

  1. Correctly preserve other issuer config params 

    When setting a new default issuer, our helper function would overwrite
other parameters in the issuer configuration entry. However, up until
now, there were none.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9057108 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Add new parameter to allow default to follow new 

    This parameter will allow operators to have the default issuer
automatically update when a new root is generated or a single issuer
with a key (potentially with others lacking key) is imported.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    37f0055 View commit details
    Browse the repository at this point in the history

  2. Storage migration tests fail on new members 

    These internal members shouldn't be tested by the storage migration
code, and so should be elided from the test results.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    91f4c93 View commit details
    Browse the repository at this point in the history

  3. Follow new issuer on root generation, import 

    This updates the two places where issuers can be created (outside of
legacy CA bundle migration which already sets the default) to follow
newly created issuers when the config is set.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    facc9c6 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    9c5c0f8 View commit details
    Browse the repository at this point in the history

  5. Add documentation 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    18ceccf View commit details
    Browse the repository at this point in the history

  6. Add test for new default-following behavior 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3ae7100 View commit details
    Browse the repository at this point in the history