Split into debug and release binaries #16330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
requested review from
smacfarlane and
claire-labry
and removed request for
a team
swenson
force-pushed
the
separate-debug-build
branch
from
7905463 to
7edfea7
Compare
added 2 commits
August 2, 2022 11:41
The release binary will have debugging information stripped out (does not affect panic traces though), and the debug binary will keep them. Using `make build`: Debug: 188,506,674 bytes on darwin/arm64 (same as current build) Release: 153,418,674 bytes on darwin/arm64 Differences are larger with `make bin`.
swenson
force-pushed
the
separate-debug-build
branch
from
7edfea7 to
f7bb2c9
Compare
|
@swenson Are we still wanting this change in? I'm so sorry I missed this 🤦🏻♀️ -- Super happy to approve it if it's still needed! |
|
I mean, I'm a fan of doing this -- it reduces the size of the main binary quite a bit. But I'll defer to @mladlow and others to make the call. I'm happy to update the PR if we want to move forward. |
|
Closing in favor of #17678 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release binary will have debugging information stripped out (does
not affect panic traces though), and the debug binary will keep them.
Using
make build:Debug: 188,506,674 bytes on darwin/arm64 (same as current build)
Release: 153,418,674 bytes on darwin/arm64
Differences are larger with
make bin.