-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizing HTTP headers in the config file #12485
Merged
hghaf099
merged 26 commits into
main
from
hghaf099-VAULT-3190-Parsing-Custom-HTTP-Headers
Oct 13, 2021
+1,019
−23
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
5bf301c
Customizing HTTP headers in the config file
hghaf099 9dfa689
Add changelog, fix bad imports
hghaf099 65f3d3a
fixing some bugs
hghaf099 61c12eb
fixing interaction of custom headers and /ui
hghaf099 f4232cd
Defining a member in core to set custom response headers
hghaf099 5ec2510
missing additional file
hghaf099 6982b8a
Some refactoring
hghaf099 f804b26
Adding automated tests for the feature
hghaf099 e52db45
Changing some error messages based on some recommendations
hghaf099 06ef62f
Incorporating custom response headers struct into the request context
hghaf099 ad93253
removing some unused references
hghaf099 0905ab2
fixing a test
hghaf099 33a4aa5
changing some error messages, removing a default header value from /ui
hghaf099 92867b4
fixing a test
hghaf099 2ae11ea
wrapping ResponseWriter to set the custom headers
hghaf099 434d8cb
adding a new test
hghaf099 6a106f0
some cleanup
hghaf099 7881067
removing some extra lines
hghaf099 e266713
Addressing comments
hghaf099 879d489
fixing some agent tests
hghaf099 2b7dd50
skipping custom headers from agent listener config,
hghaf099 0964ef8
Removing default custom headers, and renaming some function varibles
hghaf099 96cb6df
Merge branch 'main' into hghaf099-VAULT-3190-Parsing-Custom-HTTP-Headers
hghaf099 b6eedd1
some refacotring
hghaf099 08d0157
Refactoring and addressing comments
hghaf099 5734ab1
removing a function and fixing comments
hghaf099 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Customizing HTTP headers in the config file
- Loading branch information
commit 5bf301c17800829c854f9d811932f4fc43676acc
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be
fmt.Errorf()
since you're doing a format stringThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done