Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: restart template runner on retry for unlimited retries #11775

Merged
merged 26 commits into from
Jun 21, 2021
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
2609f7c
agent: restart template runner on retry for unlimited retries
calvn Jun 4, 2021
a521f1d
template: log error message early
calvn Jun 4, 2021
83e2d94
template: delegate retries back to template if param is set to true
calvn Jun 4, 2021
20af485
agent: add and use the new template config stanza
calvn Jun 9, 2021
4c23bad
agent: fix panic, fix existing tests
calvn Jun 10, 2021
b346dd8
changelog: add changelog entry
calvn Jun 10, 2021
89fa90d
agent: add tests for exit_on_retry_failure
calvn Jun 11, 2021
0b834db
Merge remote-tracking branch 'origin/master' into agent-template-retr…
calvn Jun 11, 2021
518ed86
agent: properly check on agent exit cases, add separate tests for mis…
calvn Jun 11, 2021
27df22b
agent: add note on difference between missing key vs missing secret
calvn Jun 11, 2021
300dc8c
docs: add docs for template_config
calvn Jun 12, 2021
3cf2e48
Update website/content/docs/agent/template-config.mdx
calvn Jun 14, 2021
310f564
Update website/content/docs/agent/template-config.mdx
calvn Jun 14, 2021
d7b42ac
Update website/content/docs/agent/template-config.mdx
calvn Jun 16, 2021
4f673d8
Update website/content/docs/agent/template-config.mdx
calvn Jun 16, 2021
ddccb43
Update website/content/docs/agent/template-config.mdx
calvn Jun 16, 2021
b7ecf45
docs: fix exit_on_retry_failure, fix Functionality section
calvn Jun 16, 2021
3657ea6
docs: update interaction title
calvn Jun 17, 2021
ffe15f5
template: add internal note on behavior for persist case
calvn Jun 17, 2021
1440475
docs: update agent, template, and template-config docs
calvn Jun 18, 2021
9a73bb5
docs: update agent docs on retry stanza
calvn Jun 18, 2021
69b3204
Apply suggestions from code review
calvn Jun 18, 2021
5d41bee
Update changelog/11775.txt
calvn Jun 18, 2021
8e6be32
agent/test: rename expectExit to expectExitFromError
calvn Jun 18, 2021
b3dea46
agent/test: add check on early exits on the happy path
calvn Jun 19, 2021
08be22d
Update website/content/docs/agent/template-config.mdx
calvn Jun 21, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: update agent docs on retry stanza
  • Loading branch information
calvn committed Jun 18, 2021
commit 9a73bb5b429dcf3f0d7496055733a556f336d03e
17 changes: 12 additions & 5 deletions website/content/docs/agent/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ templates, or are proxied requests coming from the proxy cache subsystem.
Auto-auth, however, has its own notion of retrying and is not affected by this
section.

For requests from the templating engine, Agent will restart its internal runner
and perform retries again once all retries are exhausted unless
`exit_after_retry_failure` from the
[`template_config`](/docs/agent/template-config) stanza is set to `true`.
For requests from the templating engine, Agent will reset its retry counter and
perform retries again once all retries are exhausted. This means that templating
will retry on failures indefinitely unless `exit_after_retry_failure` from the
[`template_config`][template-config] stanza is set to `true`.

Here are the options for the `retry` stanza:

Expand All @@ -121,7 +121,13 @@ result codes: any 50x code except 501 ("not implemented"), as well as 412
stale read due to eventual consistency. Requests coming from the template
subsystem are retried regardless of the failure.

Second, the backoff algorithm used to set the time between retries differs for
Second, templating retries may be performed by both the templating engine _and_
the cache proxy if Agent [persistent
cache][persitent-cache] is enabled. This is due to the
fact that templating requests go through the cache proxy when persistence is
enabled.

Third, the backoff algorithm used to set the time between retries differs for
the template and cache subsystems. This is a technical limitation we hope
to address in the future.

Expand Down Expand Up @@ -205,6 +211,7 @@ template {
[vault]: /docs/agent#vault-stanza
[autoauth]: /docs/agent/autoauth
[caching]: /docs/agent/caching
[persitent-cache]: /docs/agent/caching/persistent-caches
[template]: /docs/agent/template
[template-config]: /docs/agent/template-config
[listener]: /docs/agent#listener-stanza
Expand Down