Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation for multiple vault-k8s replicas #10659

Merged
merged 7 commits into from
Jan 7, 2021

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Jan 6, 2021

Describes the setup and config for using multiple injector replicas
with auto and manual TLS.

Related to hashicorp/vault-k8s#198 and hashicorp/vault-helm#436

Describes the setup and config for using multiple injector replicas
with auto and manual TLS.
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! You've done a really nice job distilling lots of options down into a digestible explanation. Reading through it just makes me wonder whether perhaps I should have made multiple replicas the default 🤔

@tvoran
Copy link
Member Author

tvoran commented Jan 6, 2021

@tomhjp Thanks for the notes! I think leaving the default replicas at 1 is fine for now, since that'll mean fewer surprises for folks when they upgrade their charts.

Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point about upgrades 👍

@tvoran tvoran merged commit 6e5bd71 into master Jan 7, 2021
@tvoran tvoran deleted the docs/VAULT-1184/vault-k8s-0.7.0 branch January 7, 2021 20:22
github-actions bot pushed a commit that referenced this pull request Jan 7, 2021
Describes the setup and config for using multiple injector replicas
with auto and manual TLS.

Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants