-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation for multiple vault-k8s replicas #10659
Conversation
Describes the setup and config for using multiple injector replicas with auto and manual TLS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! You've done a really nice job distilling lots of options down into a digestible explanation. Reading through it just makes me wonder whether perhaps I should have made multiple replicas the default 🤔
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
@tomhjp Thanks for the notes! I think leaving the default replicas at 1 is fine for now, since that'll mean fewer surprises for folks when they upgrade their charts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point about upgrades 👍
Describes the setup and config for using multiple injector replicas with auto and manual TLS. Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
Describes the setup and config for using multiple injector replicas
with auto and manual TLS.
Related to hashicorp/vault-k8s#198 and hashicorp/vault-helm#436