Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Vault Helm to 0.9.0 #10656

Merged
merged 8 commits into from
Jan 5, 2021
Merged

docs: update Vault Helm to 0.9.0 #10656

merged 8 commits into from
Jan 5, 2021

Conversation

jasonodonnell
Copy link
Contributor

Vault Helm 0.9.0 was just released so I added the new configurables and updated relevant documentation.

@jasonodonnell jasonodonnell changed the title Docs helm 0.9.0 docs: update Vault Helm to 0.9.0 Jan 5, 2021
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions.

I also see that the injector affinity default is no longer null, so we should probably update that in the docs as well.

website/content/docs/platform/k8s/helm/configuration.mdx Outdated Show resolved Hide resolved
website/content/docs/platform/k8s/helm/configuration.mdx Outdated Show resolved Hide resolved
website/content/docs/platform/k8s/helm/configuration.mdx Outdated Show resolved Hide resolved
jasonodonnell and others added 4 commits January 5, 2021 15:16
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@jasonodonnell
Copy link
Contributor Author

@tvoran Good call, updated the affinity default for the injector. Thanks for the suggestions 👍

Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small oops.

website/content/docs/platform/k8s/helm/configuration.mdx Outdated Show resolved Hide resolved
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@jasonodonnell jasonodonnell merged commit fc1f25b into master Jan 5, 2021
@jasonodonnell jasonodonnell deleted the docs-helm-0.9.0 branch January 5, 2021 21:46
jasonodonnell added a commit that referenced this pull request Jan 5, 2021
* docs: update vault-helm for 0.9.0

* Fix typo in leaderElector config

* Add default value to ttl

* Update website/content/docs/platform/k8s/helm/configuration.mdx

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

* Update website/content/docs/platform/k8s/helm/configuration.mdx

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

* Update website/content/docs/platform/k8s/helm/configuration.mdx

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

* Add affinity default for injector

* Update website/content/docs/platform/k8s/helm/configuration.mdx

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants