Adds ability to use JSON pointer for the user claim #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
approved these changes
May 16, 2022
This was referenced May 16, 2022
This was referenced May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR allows users to define the
user_claimvalue as a JSON pointer. It introduces a new boolean parameter on the role,UserClaimJSONPointer, which allows users to opt in to the behavior.The decision to make this configurable was made to preserve existing behavior. For example, an existing role could have a
user_claimvalue that is a valid JSON pointer to a different claim. This would result in an unexpected alias change. We want to prevent that from happening.Closes #180
Testing
I've added tests to this PR. I've also done some manual testing.