Add namespace and log level annotations #82
Conversation
jasonodonnell
force-pushed
the
namespaces
branch
from
7cd4f04
to
41ed03e
Compare
agent-inject/agent/container_env.go
Outdated
| @@ -10,6 +10,11 @@ import ( | |||
| func (a *Agent) ContainerEnvVars(init bool) ([]corev1.EnvVar, error) { | |||
| var envs []corev1.EnvVar | |||
|
|
|||
| envs = append(envs, corev1.EnvVar{ | |||
| Name: "VAULT_TOKEN", | |||
| Value: "/home/vault/.vault-token", | |||
There was a problem hiding this comment.
Should this use the TokenFile const?
vault-k8s/agent-inject/agent/config.go
Line 14 in 41ed03e
There was a problem hiding this comment.
Shouldn't this environment variable hold the contents of the token instead? cf. https://www.vaultproject.io/docs/commands/#vault_token
There was a problem hiding this comment.
There's a bug with Kube auth login and namespaces that we haven't been able to track down, so setting this was the only way to get it to work. Auto-auth populates file cache which takes priority. This could be any value.
There was a problem hiding this comment.
I can put a comment in about this being a work around until we find the bug in the auth method.
There was a problem hiding this comment.
I see. I think this might affect the auto-revoke on shutdown that I implemented in #67
There was a problem hiding this comment.
I will test the two together and let you know.
There was a problem hiding this comment.
@lawliet89 I found a less intrusive solution. This shouldn't cause issues for you!
|
Really looking forward to this PR going in 😄 Great work! |
* Add namespace and log level annotations * Remove env, add blank token file * Fix tests * gofmt
This resolves #20 by adding Vault namespace support for enterprise installations. Additionally when debugging namespace features, I needed to increase log level. This adds another annotation to change the Vault Agent log level (default to
info).