-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Vault Token to the usual location #66
Write Vault Token to the usual location #66
Conversation
As documented by the default token helper: https://www.vaultproject.io/docs/commands/token-helper/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine here. Minor feedback, thanks for the contribution!
@@ -104,7 +104,7 @@ func (a *Agent) newConfig(init bool) ([]byte, error) { | |||
}, | |||
AutoAuth: &AutoAuth{ | |||
Method: &Method{ | |||
Type: "kubernetes", | |||
Type: "kubernetes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random whitespace? Can you run gofmt
on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run go fmt
. The space seem to have been added by gofmt
to match the line right below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
* Write Vault Token to the usual location As documented by the default token helper: https://www.vaultproject.io/docs/commands/token-helper/ * Fix gofmt
As documented by the default token helper: https://www.vaultproject.io/docs/commands/token-helper/