Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Vault Token to the usual location #66

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

lawliet89
Copy link
Contributor

As documented by the default token helper: https://www.vaultproject.io/docs/commands/token-helper/

Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine here. Minor feedback, thanks for the contribution!

@@ -104,7 +104,7 @@ func (a *Agent) newConfig(init bool) ([]byte, error) {
},
AutoAuth: &AutoAuth{
Method: &Method{
Type: "kubernetes",
Type: "kubernetes",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random whitespace? Can you run gofmt on this?

Copy link
Contributor Author

@lawliet89 lawliet89 Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run go fmt. The space seem to have been added by gofmt to match the line right below.

Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@jasonodonnell jasonodonnell merged commit 9cf1a9b into hashicorp:master Feb 14, 2020
@jasonodonnell jasonodonnell added this to the 0.3.0 milestone Feb 20, 2020
@jasonodonnell jasonodonnell mentioned this pull request Mar 4, 2020
NLRemco pushed a commit to NLRemco/vault-k8s that referenced this pull request Feb 22, 2022
* Write Vault Token to the usual location

As documented by the default token helper: https://www.vaultproject.io/docs/commands/token-helper/

* Fix gofmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants