Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agent-inject-containers-annotation #313

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Add agent-inject-containers-annotation #313

merged 5 commits into from
Jan 28, 2022

Conversation

HamzaZo
Copy link
Contributor

@HamzaZo HamzaZo commented Jan 16, 2022

Due to lack of activity in PR #163, I continued the work in this PR.

@HamzaZo HamzaZo mentioned this pull request Jan 16, 2022
Closed
@HamzaZo
Copy link
Contributor Author

HamzaZo commented Jan 16, 2022

Hello @tvoran

I update the code based on your comments in #245, could you please review it ?

@tvoran tvoran added enhancement New feature or request injector Area: mutating webhook service labels Jan 18, 2022
@tvoran tvoran self-requested a review January 19, 2022 07:08
tvoran
tvoran reviewed Jan 27, 2022
View reviewed changes
agent-inject/agent/agent.go Outdated Show resolved Hide resolved
tvoran
tvoran approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for pushing this forward!

@tvoran tvoran merged commit 286c36f into hashicorp:main Jan 28, 2022
@HamzaZo HamzaZo deleted the feat/add-agent-inject-containers-annotation branch January 28, 2022 10:11
NLRemco pushed a commit to NLRemco/vault-k8s that referenced this pull request Feb 22, 2022
@HamzaZo
Add agent-inject-containers-annotation (hashicorp#313)
ede4fb5
@ravilr
Copy link
Contributor

ravilr commented Mar 21, 2022

Hi @tvoran, now that this is released as part of 0.15.0, this annotation still doesn't show up in docs here: https://www.vaultproject.io/docs/platform/k8s/injector/annotations . Thanks.

@tvoran
Copy link
Member

tvoran commented Mar 30, 2022

@ravilr Thanks, it should be there now as of hashicorp/vault#14776.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request injector Area: mutating webhook service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HamzaZo @ravilr @tvoran