Add annotations for customizing template delimiters #226
+59
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tvoran
added
enhancement
|
Is this still going to be added? |
|
Why this feature was never merged or checked at some point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can override the default delimiters with the vault injector by defining a config file via a configmap https://www.vaultproject.io/docs/agent/template#left_delimiter. That isn't always an ideal way to handle templating a secret, especially when using Helm
There is some difficulty when using the vault injector template via annotations, especially when using it in conjunction with Helm. See #68
This PR adds functionality to define the left and right delimiters via annotations.