Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations for customizing template delimiters #226

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

caitlinelfring
Copy link

@caitlinelfring caitlinelfring commented Mar 3, 2021

Currently, you can override the default delimiters with the vault injector by defining a config file via a configmap https://www.vaultproject.io/docs/agent/template#left_delimiter. That isn't always an ideal way to handle templating a secret, especially when using Helm

There is some difficulty when using the vault injector template via annotations, especially when using it in conjunction with Helm. See #68

This PR adds functionality to define the left and right delimiters via annotations.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 3, 2021

CLA assistant check
All committers have signed the CLA.

@tvoran tvoran self-requested a review September 8, 2021 00:59
@tvoran tvoran added enhancement New feature or request injector Area: mutating webhook service labels Sep 8, 2021
@sudomann
Copy link

Is this still going to be added?

@Diliz
Copy link

Diliz commented Jul 8, 2024

Why this feature was never merged or checked at some point?

@Diliz Diliz mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request injector Area: mutating webhook service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants