-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export prometheus metrics #145
Conversation
cc/ @jasonodonnell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @diogonicoleti, this looks great! Thanks for adding this feature.
I think this should be an opt-in feature, so the handler should be enabled via flag/env (we can add configurables to Vault Helm to enable/disable it). The reason I think it should be opt-in is we don't own the metric code being served by the handler, so if there's an issue upstream that causes a panic, it can bring down the whole injector.
Thoughts?
@jasonodonnell done! I added a new flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
* Add Prometheus metrics endpoint * Add flag to define telemetry path * Upgrade prometheus client dependency
I would like to monitor some behaviors of the injector, so I added the
metrics
endpoint that export some prometheus metrics.Just for now, this just export the default metrics for go apps, but we can add injector specific metrics in the future (like this one: #17).