Export prometheus metrics #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc/ @jasonodonnell |
ahilsend
approved these changes
Jul 2, 2020
jasonodonnell
suggested changes
Jul 9, 2020
There was a problem hiding this comment.
Hey @diogonicoleti, this looks great! Thanks for adding this feature.
I think this should be an opt-in feature, so the handler should be enabled via flag/env (we can add configurables to Vault Helm to enable/disable it). The reason I think it should be opt-in is we don't own the metric code being served by the handler, so if there's an issue upstream that causes a panic, it can bring down the whole injector.
Thoughts?
|
@jasonodonnell done! I added a new flag |
Kampe
approved these changes
Aug 12, 2020
This was referenced Aug 20, 2020
Merged
NLRemco
pushed a commit
to NLRemco/vault-k8s
that referenced
this pull request
Feb 22, 2022
* Add Prometheus metrics endpoint * Add flag to define telemetry path * Upgrade prometheus client dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to monitor some behaviors of the injector, so I added the
metricsendpoint that export some prometheus metrics.Just for now, this just export the default metrics for go apps, but we can add injector specific metrics in the future (like this one: #17).