added extra-secret annotation for adding kube-secrets #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcman312
added
enhancement
|
What is the status here? We also would prefer using Kube secrets instead of directly writing files. |
tvoran
approved these changes
Sep 10, 2020
|
Awesome! I look forward to the official release of this feature. |
|
same here @lcgkm - we have a Vault Endpoint that "in the cloud" but our k8s cluster is on prem and thus the k8s auth just doesn't work for us. I am also hoping we can get a learn article (or even just a Readme.md in this repo) for examples on how this feature can be used (specifically against something like approle!) |
NLRemco
pushed a commit
to NLRemco/vault-k8s
that referenced
this pull request
Feb 22, 2022
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds annotation:
vault.hashicorp.com/agent-extra-secret: <somekubesecret>which will mount the supplied Kubernetes secret as a volume at
/vault/customin the sidecar/init containers. Useful for custom Agent configs with auto-auth methods such as approle that require paths to secrets be present.To use: create a custom agent configmap (with config.hcl or config-init.hcl as secret keys), create a deployment with the new annotation, create a Kube secret with the roleid/secretid/other secret you reference from your configmap (/vault/custom/somesecret).