Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ha standby and active annotations #268

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Fix ha standby and active annotations #268

merged 2 commits into from
Apr 21, 2020

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Apr 21, 2020

No description provided.

@tvoran tvoran mentioned this pull request Apr 21, 2020
Closed
jasonodonnell
jasonodonnell approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvoran tvoran merged commit 2072bf2 into master Apr 21, 2020
@tvoran tvoran deleted the fix-ha-annotations branch April 21, 2020 15:19
@kauedg
Copy link

kauedg commented May 19, 2020

Both files server-ha-active-service.yaml and server-ha-standby-service.yaml have the same comment:
# Service for active Vault pod

Maybe it should be # Service for standby Vault pod in server-ha-standby-service.yaml

@tvoran tvoran added this to the v0.6.0 milestone May 22, 2020
@tvoran
Copy link
Member Author

tvoran commented May 22, 2020

@kauedg Yep, fixed in #299

radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
@tvoran @yotsub
Fix ha standby and active service annotations (hashicorp#268)
a562f4e 
* service: fix annotations for HA standby/active services

* added unit tests

Co-authored-by: yotsub <63680950+yotsub@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tvoran @kauedg @jasonodonnell @yotsub