Add support for UDP forwarding #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soapy1
reviewed
Sep 27, 2021
| f.logger.Debug("initializing new connection stream", "fwd", f, "source", conn.RemoteAddr()) | ||
| go f.stream(conn, target, completed) | ||
| go f.stream(target, conn, completed) | ||
| if f.Fwd.Host.Type == "" || strings.Contains(f.Fwd.Host.Type, "udp") { |
There was a problem hiding this comment.
Suggested change
| if f.Fwd.Host.Type == "" || strings.Contains(f.Fwd.Host.Type, "udp") { | |
| if strings.Contains(f.Fwd.Host.Type, "udp") { |
I think this shouldn't have the || bit. From the Vagrant documentation
Either "udp" or "tcp". This specifies the protocol that will be allowed through the forwarded port. By default this is "tcp".
So, if udp is not specified as the type Vagrant should not forward using udp.
There was a problem hiding this comment.
👍 originally when I wrote this it was with the intention of imitating vmware's default behavior (which is just forward everything) but the plugin internally will specify tcp by default when no value is provided and I didn't want to modify that behavior. Will back that bit out 🙂
chrisroberts
force-pushed
the
udp-forward
branch
from
164e365
to
afd07f5
Compare
soapy1
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for UDP port forwards in the internal forwarding implementation.
Fixes #11