Skip to content

Conversation

@AndrewCharlesHay
Copy link
Contributor

@AndrewCharlesHay AndrewCharlesHay commented Dec 27, 2025

Removes a stale FIXME comment in internal/builtin/providers/terraform/provider.go. The suggested validation logic is already present in dataSourceRemoteStateValidate.

Connection to OpenTofu

This stale FIXME was also identified in the OpenTofu fork. An identical cleanup has been submitted to OpenTofu in opentofu/opentofu#3625.

Timeline:

  1. July 2018: The FIXME was introduced in builtin/providers: terraform remote state datasource #18446 when the provider was created.
  2. May 2019: The validation logic was implemented in providers/terraform: Explicit validate step #21205, but the FIXME comment was accidentally left behind.
  3. Dec 2025: This PR removes the stale comment.

Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com>
@AndrewCharlesHay AndrewCharlesHay requested a review from a team as a code owner December 27, 2025 18:46
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Dec 27, 2025

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com>
Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com>
@radeksimko radeksimko added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Dec 30, 2025
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. Would you mind removing the changelog entry (as this change is not user-facing) and signing the CLA?

Also, for anyone else reading this in the future, the PR which implemented the validation is #21205 (different from the one mentioned, probably by mistake)

Signed-off-by: Andrew Hay <andrew.hay@benchmarkanalytics.com>
@AndrewCharlesHay
Copy link
Contributor Author

I updated PR description and signed the CLA and removed the changelog entry

@radeksimko radeksimko enabled auto-merge (squash) January 5, 2026 11:01
@radeksimko radeksimko merged commit e3263be into hashicorp:main Jan 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants