Backport of actions: remove unused variable (+ minor typos & comment cleanup) into v1.14 #37816
+9
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
backport/mildwonkey/action-nitpicks/lately-caring-marmoset
branch
from
01184ff to
1a77653
Compare
mildwonkey
approved these changes
Oct 27, 2025
|
This will wait till rc2 or v1.14.1 |
Changelog WarningCurrently this PR would target a v1.14 release. Please add a changelog entry for in the .changes/v1.14 folder, or discuss which release you'd like to target with your reviewer. If you believe this change does not need a changelog entry, please add the 'no-changelog-needed' label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #37804 to be assessed for backporting due to the inclusion of the label 1.14-backport.
The below text is copied from the body of the original PR.
There are two commits here, because I had a handful of comment fixes and typos to clean up ready to go before I noticed this. I removed any file that only had typos in comments, so these files should only include user facing typos or updated comments (still very very minor).
The actual change of interest is in the first commit, in transform_action_diff, and is smol: I noticed the
applyNodesweren't in use anymore and could be removed. (also vscode was really excited about changing that one if statement to a switch; I don't think I care.)Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry
Overview of commits
d72232b
3e5f3a1