Skip to content

Conversation

@mildwonkey
Copy link
Contributor

I misconfigured a test and had the sudden realization that certain validations had gotten lost - crucially, we were no longer validating that the action referenced inside a resource's ActionTriggers existed inside the config. Very early on, that happened during configload, but it was based on flawed implementation (my mistake! what is a terraform, even?) and the validation was removed when I fixed my improper handling.

I tried a few options but decided that this particular validation fit best in the configuration transformation process, as it is a matter of connecting the resource's action to the action configuration. I took some inspiration from validateImportTargets code, mostly in how I crafted the error, and in deciding to return after validating the actions if an error is encountered. I'm open to alternate suggestions!

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@mildwonkey mildwonkey added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Sep 3, 2025
@mildwonkey mildwonkey requested a review from a team as a code owner September 3, 2025 19:50
@mildwonkey mildwonkey force-pushed the mildwonkey/action-trigger-validation branch from 2ebd207 to f8f3ceb Compare September 4, 2025 12:02
@mildwonkey mildwonkey force-pushed the mildwonkey/action-trigger-validation branch from f8f3ceb to 4e998bb Compare September 5, 2025 14:00
@mildwonkey mildwonkey merged commit f574c9c into main Sep 8, 2025
7 checks passed
@mildwonkey mildwonkey deleted the mildwonkey/action-trigger-validation branch September 8, 2025 12:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants