Actions: handle providers deferring actions #37465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
added
the
no-changelog-needed
DanielMSchmidt
force-pushed
the
TF-27458
branch
2 times, most recently
from
19ab98b to
56fcd00
Compare
DanielMSchmidt
force-pushed
the
TF-27458
branch
from
56fcd00 to
1ec74c7
Compare
dleehr
reviewed
Aug 24, 2025
DanielMSchmidt
force-pushed
the
TF-27458
branch
from
f1aab13 to
aee6078
Compare
liamcervante
previously approved these changes
Aug 25, 2025
internal/terraform/context_plan.go
Outdated
| } | ||
|
|
||
| if !schemaDiags.HasErrors() { | ||
| deferredResources, deferredDiags := c.deferredResources(config, walker.Deferrals.GetDeferredChanges(), priorState) |
Member
There was a problem hiding this comment.
nit: you could refactor this so it uses the shared schemas as well?
liamcervante
approved these changes
Aug 25, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lot of logistics around deferrals and makes providers reporting deferrals be reflected in the plan (and the dependent actions / resources).
I omitted the expansion of resources with unknown values from this PR and will do it in a follow up to limit the scope a bit.
Fixes #
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry