Skip to content

actions: add more test cases to ensure destroying is no issue #37340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

actions: add more test cases to ensure destroying is no issue #37340

merged 1 commit into from
Jul 18, 2025

Conversation

@DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Jul 17, 2025 •
edited
Loading

Very small PR that adds two test cases related to destroying to ensure destroying is no problem (it was no problem, but better safe than sorry)

Fixes TF-27462

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner July 17, 2025 14:45
@DanielMSchmidt DanielMSchmidt added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Jul 17, 2025
mildwonkey
mildwonkey previously approved these changes Jul 17, 2025
View reviewed changes
@DanielMSchmidt DanielMSchmidt force-pushed the TF-25936 branch 3 times, most recently from a220e15 to 9e73ed4 Compare July 18, 2025 09:26
Base automatically changed from TF-25936 to main July 18, 2025 11:07
@DanielMSchmidt DanielMSchmidt dismissed mildwonkey’s stale review July 18, 2025 11:07

The base branch was changed.

@DanielMSchmidt DanielMSchmidt merged commit 303dc90 into main Jul 18, 2025
12 checks passed
@DanielMSchmidt DanielMSchmidt deleted the TF-27462 branch July 18, 2025 12:12
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mildwonkey mildwonkey mildwonkey approved these changes

Assignees

No one assigned

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielMSchmidt @mildwonkey