initial actions addrs #37003
Merged
initial actions addrs #37003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildwonkey
added
the
no-changelog-needed
mildwonkey
force-pushed
the
mildwonkey/action-addrs
branch
from
8cdd551 to
22e2a98
Compare
This adds the basic Action-related addresses and parsing Actions as references.
mildwonkey
force-pushed
the
mildwonkey/action-addrs
branch
from
2b52465 to
73c60a9
Compare
Maed223
pushed a commit
that referenced
this pull request
May 13, 2025
* initial actions addrs This adds the basic Action-related addresses and parsing Actions as references.
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the most basic Action-related addresses and parsing Actions as references. This is the very beginning of adding actions, so the details are subject to change as we work through the implementation. There is no user impacting code (nor will there be, for some time!)
There may be bits in here we don't need, I will keep an eye on this package and make sure anything that's overdesigned gets removed. Actions work a lot like resources, so I copied everything except the Mode (irrelevant) and Target/Checkable interface implementations. Actions will be Checkable in the future, but not yet, and Actions are targetable by design (invoke is, in effect, targeting). (I also won't be surprised if I end up stealing "targetable" for invocations, who knows what the future holds?!)
The tests are also basically copy-pasted - if we didn't test a resource method, i didn't test the action method. No objection to writing more but at best, these aren't all that useful. (Maybe it's faster to say: when I'm writing new logic you'll see more tests. This is just a lot of the same code).
Apologies, but I need to do this, for me:
