Use iterators for graph vertices #36558
Conversation
dsa0x
force-pushed
the
sams/graph-iter
branch
from
520ba28 to
2dbb6dc
Compare
dsa0x
added
the
no-changelog-needed
dsa0x
force-pushed
the
sams/graph-iter
branch
from
2dbb6dc to
d519339
Compare
internal/dag/seq.go
Outdated
| // SelectSeq filters a sequence to include only elements that can be type-asserted to type U. | ||
| // It returns a new sequence containing only the matching elements. | ||
| // The yield function can return false to stop iteration early. | ||
| func SelectSeq[T Vertex, U Vertex](seq VertexSeq[T], filter func(U)) VertexSeq[U] { |
There was a problem hiding this comment.
I think we don't need the filter function at all here? It's not being called, and you can specify the type using the [...] syntax: SelectSeq[MockVertex2, MockVertex](...).
There was a problem hiding this comment.
It was only there so that the type can be inferred, instead of the compulsory type constraint like this syntax, but it is probably better to use the natural syntax. Also, we actually only needed a single type constraint.
One type parameter seem to be enough instead of 2
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #
Target Release
1.13.x
CHANGELOG entry