Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement plan -out with cloud integration #33418

Merged
merged 9 commits into from
Jul 6, 2023
Merged

Implement plan -out with cloud integration #33418

merged 9 commits into from
Jul 6, 2023

Commits on Jun 29, 2023

  1. Upgrade to go-tfe v1.29.0 (for saved plan run support)

    @nfagerlund
    nfagerlund committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    1e16a9e View commit details
    Browse the repository at this point in the history

  2. Add NewSavedPlanBookmark function 

    so we don't have to remember the format version number
    @nfagerlund
    nfagerlund committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    11743d1 View commit details
    Browse the repository at this point in the history

  3. Implement plan -out for cloud, maybe

    @nfagerlund
    nfagerlund committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    5c56ca9 View commit details
    Browse the repository at this point in the history

  4. Call op.View.PlanNextStep for terraform plan in cloud mode 

    This displays the footer that explains what happens if you saved a plan file (or
neglected to). We never used to show it, because we didn't support -out.
    @nfagerlund
    nfagerlund committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    eef35b9 View commit details
    Browse the repository at this point in the history

  5. Rewrite TestCloud_planWithPath to expect success!

    @nfagerlund
    nfagerlund committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    f67a5da View commit details
    Browse the repository at this point in the history

  6. Fix wonky logic for combining plan errors and save errors 

    This was wrong when err != nil and saveErr == nil.
    @nfagerlund
    nfagerlund committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    aad14b4 View commit details
    Browse the repository at this point in the history

  7. Don't save errored plans 

    On further consideration, this is a nonsensical thing to do, and it doesn't
match the behavior of plain CLI!

Additionally, skip next steps message on failure.
    @nfagerlund
    nfagerlund committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    fecb608 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Cloud actually DOES support genconfig!

    @nfagerlund
    nfagerlund committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    213064d View commit details
    Browse the repository at this point in the history

  2. Clarify nils in returns: you get run, OR err

    @nfagerlund
    nfagerlund committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    38858b9 View commit details
    Browse the repository at this point in the history