provider/alicloud: Add new resource ESS, including scalinggroup scalingconfiguration scalingrule and schedule

[demonwy]

IMPROVEMENTS:

• resource/alicloud_instance: delete ecs instance with retry (#113)

BUG FIXES:

• resource/resource_alicloud_security_group_rule: check ptr before use it.(#113)
• resource/alicloud_instance: fix ecs internet_max_bandwidth_out cannot set zero bug. cause if don't want allocate public ip, then must set internet_max_bandwidth_out is zero.(#105)

FEATURES:

• New Resource: alicloud_ess_scalinggroup (#113)
• New Resource: alicloud_ess_scalingconfiguration (#113)
• New Resource: alicloud_ess_scalingrule (#113)
• New Resource: alicloud_ess_schedule (#113)
• New Resource: alicloud_snat_entry (#105)
• New Resource: alicloud_forward_entry (#105)
• add snat entry and forward entry template sample in /terraform/examples/alicloud-vpc-snat.

[demonwy]

Acc Test result as below:

TF_ACC=1 go test -v ./alicloud -run=TestAccAlicloud -timeout=180m -parallel=4
=== RUN TestAccAlicloudImagesDataSource_images
--- PASS: TestAccAlicloudImagesDataSource_images (34.51s)
=== RUN TestAccAlicloudImagesDataSource_owners
--- PASS: TestAccAlicloudImagesDataSource_owners (19.78s)
=== RUN TestAccAlicloudImagesDataSource_ownersEmpty
--- PASS: TestAccAlicloudImagesDataSource_ownersEmpty (23.01s)
=== RUN TestAccAlicloudImagesDataSource_nameRegexFilter
--- PASS: TestAccAlicloudImagesDataSource_nameRegexFilter (21.83s)
=== RUN TestAccAlicloudImagesDataSource_imageNotInFirstPage
--- PASS: TestAccAlicloudImagesDataSource_imageNotInFirstPage (22.73s)
=== RUN TestAccAlicloudInstanceTypesDataSource_basic
--- PASS: TestAccAlicloudInstanceTypesDataSource_basic (36.88s)
=== RUN TestAccAlicloudRegionsDataSource_regions
--- PASS: TestAccAlicloudRegionsDataSource_regions (16.17s)
=== RUN TestAccAlicloudRegionsDataSource_name
--- PASS: TestAccAlicloudRegionsDataSource_name (14.63s)
=== RUN TestAccAlicloudRegionsDataSource_current
--- PASS: TestAccAlicloudRegionsDataSource_current (14.17s)
=== RUN TestAccAlicloudRegionsDataSource_empty
--- PASS: TestAccAlicloudRegionsDataSource_empty (14.29s)
=== RUN TestAccAlicloudZonesDataSource_basic
--- PASS: TestAccAlicloudZonesDataSource_basic (15.18s)
=== RUN TestAccAlicloudZonesDataSource_filter
--- PASS: TestAccAlicloudZonesDataSource_filter (24.50s)
=== RUN TestAccAlicloudZonesDataSource_unitRegion
--- PASS: TestAccAlicloudZonesDataSource_unitRegion (14.91s)
=== RUN TestAccAlicloudDBInstance_basic
--- PASS: TestAccAlicloudDBInstance_basic (427.04s)
=== RUN TestAccAlicloudDBInstance_vpc
--- PASS: TestAccAlicloudDBInstance_vpc (456.83s)
=== RUN TestAccAlicloudDBInstance_multiIZ
--- PASS: TestAccAlicloudDBInstance_multiIZ (425.33s)
=== RUN TestAccAlicloudDBInstance_database
--- PASS: TestAccAlicloudDBInstance_database (513.17s)
=== RUN TestAccAlicloudDBInstance_account
--- PASS: TestAccAlicloudDBInstance_account (573.05s)
=== RUN TestAccAlicloudDBInstance_allocatePublicConnection
--- PASS: TestAccAlicloudDBInstance_allocatePublicConnection (561.05s)
=== RUN TestAccAlicloudDBInstance_backupPolicy
--- PASS: TestAccAlicloudDBInstance_backupPolicy (466.90s)
=== RUN TestAccAlicloudDBInstance_securityIps
--- PASS: TestAccAlicloudDBInstance_securityIps (521.24s)
=== RUN TestAccAlicloudDBInstance_upgradeClass
--- PASS: TestAccAlicloudDBInstance_upgradeClass (819.80s)
=== RUN TestAccAlicloudDiskAttachment
--- PASS: TestAccAlicloudDiskAttachment (138.10s)
=== RUN TestAccAlicloudDisk_basic
--- PASS: TestAccAlicloudDisk_basic (77.08s)
=== RUN TestAccAlicloudDisk_withTags
--- PASS: TestAccAlicloudDisk_withTags (73.92s)
=== RUN TestAccAlicloudEIPAssociation
--- PASS: TestAccAlicloudEIPAssociation (102.51s)
=== RUN TestAccAlicloudEIP_basic
--- PASS: TestAccAlicloudEIP_basic (28.88s)
=== RUN TestAccAlicloudEssScalingConfiguration_basic
--- PASS: TestAccAlicloudEssScalingConfiguration_basic (23.41s)
=== RUN TestAccAlicloudEssScalingConfiguration_multiConfig
--- PASS: TestAccAlicloudEssScalingConfiguration_multiConfig (36.12s)
=== RUN TestAccAlicloudEssScalingGroup_basic
--- PASS: TestAccAlicloudEssScalingGroup_basic (36.02s)
=== RUN TestAccAlicloudEssScalingGroup_update
--- PASS: TestAccAlicloudEssScalingGroup_update (19.03s)
=== RUN TestAccAlicloudEssScalingRule_basic
--- PASS: TestAccAlicloudEssScalingRule_basic (19.06s)
=== RUN TestAccAlicloudEssScalingRule_update
--- PASS: TestAccAlicloudEssScalingRule_update (45.30s)
=== RUN TestAccAlicloudEssSchedule_basic
--- PASS: TestAccAlicloudEssSchedule_basic (28.27s)
=== RUN TestAccAlicloudForward_basic
--- PASS: TestAccAlicloudForward_basic (89.75s)
=== RUN TestAccAlicloudInstance_basic
--- PASS: TestAccAlicloudInstance_basic (110.92s)
=== RUN TestAccAlicloudInstance_vpc
--- PASS: TestAccAlicloudInstance_vpc (115.98s)
=== RUN TestAccAlicloudInstance_userData
--- PASS: TestAccAlicloudInstance_userData (114.21s)
=== RUN TestAccAlicloudInstance_multiSecurityGroupByCount
--- PASS: TestAccAlicloudInstance_multiSecurityGroupByCount (83.22s)
=== RUN TestAccAlicloudInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAlicloudInstance_NetworkInstanceSecurityGroups (145.73s)
=== RUN TestAccAlicloudInstance_tags
--- PASS: TestAccAlicloudInstance_tags (98.96s)
=== RUN TestAccAlicloudInstance_privateIP
--- PASS: TestAccAlicloudInstance_privateIP (102.22s)
=== RUN TestAccAlicloudInstance_associatePublicIP
--- PASS: TestAccAlicloudInstance_associatePublicIP (113.33s)
=== RUN TestAccAlicloudNatGateway_basic
--- PASS: TestAccAlicloudNatGateway_basic (82.79s)
=== RUN TestAccAlicloudNatGateway_spec
--- PASS: TestAccAlicloudNatGateway_spec (80.19s)
=== RUN TestAccAlicloudSecurityGroup_basic
--- PASS: TestAccAlicloudSecurityGroup_basic (14.75s)
=== RUN TestAccAlicloudSecurityGroup_withVpc
--- PASS: TestAccAlicloudSecurityGroup_withVpc (23.50s)
=== RUN TestAccAlicloudSlb_basic
--- PASS: TestAccAlicloudSlb_basic (17.83s)
=== RUN TestAccAlicloudSlb_traffic
--- PASS: TestAccAlicloudSlb_traffic (15.07s)
=== RUN TestAccAlicloudSlb_listener
--- PASS: TestAccAlicloudSlb_listener (21.52s)
=== RUN TestAccAlicloudSlb_vpc
--- PASS: TestAccAlicloudSlb_vpc (34.28s)
=== RUN TestAccAlicloudSnat_basic
--- PASS: TestAccAlicloudSnat_basic (89.17s)
=== RUN TestAccAlicloudVpc_basic
--- PASS: TestAccAlicloudVpc_basic (21.42s)
=== RUN TestAccAlicloudVpc_update
--- PASS: TestAccAlicloudVpc_update (33.22s)

[stack72]

LGTM! thanks for this work

Please note, that in future, it would be really helpful if a PR of this magnitude was broken down into smaller PRs. I understand that you send PRs to your own repo, but it's difficult to cross reference the code that has changed there :)

Thanks

Paul

[demonwy]

@stack72 Thanks for your kind advice.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.