Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF-6330] add org membership ID attr to tfe_organization_membership #997

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

laurenolivia
Copy link
Contributor

@laurenolivia laurenolivia commented Aug 11, 2023

Description

This PR adds the organization_membership_id to the tfe_organization_membership data source. The original feature request wanted the data source to also allow the user_id arg, however the Organization Membership API doesn't accept user_id as a query param.

Remember to:

Testing plan

  1. Use the d/tfe_organization_membership with the following arguments:
data "tfe_organization_membership" "test" {
  organization  = "my-org-name"
  organization_membership_id = "ou-xxxxxxxxxxx"
}

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFEOrganizationMembershipDataSource_basic" make testacc

--- PASS: TestAccTFEOrganizationMembershipDataSource_basic (17.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-tfe/tfe	(cached)
...
Screenshot 2023-08-11 at 2 22 51 PM

@laurenolivia laurenolivia requested a review from a team as a code owner August 11, 2023 18:07
@laurenolivia laurenolivia force-pushed the laurenolivia/add-attr-tfe-org-membership branch from 20cb79f to 4de3856 Compare August 11, 2023 20:20
@laurenolivia laurenolivia force-pushed the laurenolivia/add-attr-tfe-org-membership branch from 10534ab to f023040 Compare August 16, 2023 23:13
Copy link
Contributor

@Uk1288 Uk1288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurenolivia laurenolivia merged commit cde397b into main Aug 17, 2023
8 checks passed
@laurenolivia laurenolivia deleted the laurenolivia/add-attr-tfe-org-membership branch August 17, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow tfe_organization_membership to accept user id or membership id
2 participants