Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project_ids to variable set data source #994

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Add project_ids to variable set data source #994

merged 5 commits into from
Aug 9, 2023

Conversation

Netra2104
Copy link
Contributor

@Netra2104 Netra2104 commented Aug 8, 2023 •
edited
Loading

Description

The variable set data source exports a workspace_ids attribute containing the set of workspace ids that a varset is assigned to. For completeness, we should update the TFE provider to export a list of project_ids as well.

External links

Output from acceptance tests

/Users/netra.mali/go/go1.19.11/bin/go tool test2json -t /Users/netra.mali/Library/Caches/JetBrains/GoLand2023.1/tmp/GoLand/___TestAccTFEVariableSetsDataSource_full_in_github_com_hashicorp_terraform_provider_tfe_tfe.test -test.v -test.paniconexit0 -test.run ^\QTestAccTFEVariableSetsDataSource_full\E$
=== RUN   TestAccTFEVariableSetsDataSource_full
--- PASS: TestAccTFEVariableSetsDataSource_full (18.74s)
PASS

Screenshot 2023-08-08 at 12 08 21 PM

@Netra2104 Netra2104 marked this pull request as ready for review August 8, 2023 15:56
@Netra2104 Netra2104 requested a review from a team as a code owner August 8, 2023 15:56
@Netra2104 Netra2104 requested a review from a team August 8, 2023 15:57
hs26gill
hs26gill approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@hs26gill hs26gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Uk1288
Uk1288 reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@Uk1288 Uk1288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉

CHANGELOG.md Outdated Show resolved Hide resolved
@Netra2104 Netra2104 merged commit 46cce5a into main Aug 9, 2023
8 checks passed
@Netra2104 Netra2104 deleted the Netra2104/TF-5323-add-project-ids-to-variable-set-data-source branch August 9, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rberecka rberecka rberecka left review comments

@hs26gill hs26gill hs26gill approved these changes

@Uk1288 Uk1288 Uk1288 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Netra2104 @hs26gill @rberecka @Uk1288 @netramali