Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tfe_saml_settings data source #952

Merged
merged 3 commits into from
Jul 12, 2023
Merged

feat: add tfe_saml_settings data source #952

merged 3 commits into from
Jul 12, 2023

Conversation

karvounis-form3
Copy link
Contributor

@karvounis-form3 karvounis-form3 commented Jul 5, 2023

Description

This PR adds the datasource tfe_saml_settings. This change is required in order to add SAML settings support to the provider (documentation). Follow up PR will be to add a resource for tfe_saml_settings.

External links

Output from acceptance tests

$ TESTARGS="-run TestAccTFESAMLSettingsDataSource_basic" make testacc

TF_ACC=1 TF_LOG_SDK_PROTO=OFF go test $(go list ./... |grep -v 'vendor') -v -run TestAccTFESAMLSettingsDataSource_basic -timeout 15m
?   	github.com/hashicorp/terraform-provider-tfe	[no test files]
=== RUN   TestAccTFESAMLSettingsDataSource_basic
--- PASS: TestAccTFESAMLSettingsDataSource_basic (19.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-tfe/tfe	19.853s
?   	github.com/hashicorp/terraform-provider-tfe/version	[no test files]

@karvounis-form3 karvounis-form3 marked this pull request as ready for review July 5, 2023 19:17
@karvounis-form3 karvounis-form3 requested a review from a team as a code owner July 5, 2023 19:17
@uturunku1 uturunku1 mentioned this pull request Jul 11, 2023
Copy link
Collaborator

@uturunku1 uturunku1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks great. And I am so glad to see that you are using the terraform-plugin-framework syntax!

tfe/data_source_saml_settings_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@uturunku1 uturunku1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing now! Thank you so much for your contribution @karvounis-form3 . Whenever you are ready, please go ahead and merge your PR (as well close the Github issue).

@karvounis-form3
Copy link
Contributor Author

@uturunku1 Unfortunately, I do not have proper permissions to merge this PR

This branch has no conflicts with the base branch
Only those with [write access](https://docs.github.com/articles/what-are-the-different-access-permissions) to this repository can merge pull requests.

image

@uturunku1 uturunku1 merged commit e2f12c0 into hashicorp:main Jul 12, 2023
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants