-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow creation of registry module via Github app #935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsa0x
force-pushed
the
sams/fix-registry-module-vcs-create
branch
from
June 19, 2023 19:23
c2bede2
to
02e9aca
Compare
nfagerlund
requested changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is good! I tested it out and it behaved as expected, and the code makes sense.
There's one doc typo, after which this is mergeable.
Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com>
nfagerlund
approved these changes
Jun 28, 2023
github-merge-queue bot
referenced
this pull request
in panda-den/colorful-pandas
Jul 4, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tfe](https://registry.terraform.io/providers/hashicorp/tfe) ([source](https://togithub.com/hashicorp/terraform-provider-tfe)) | required_provider | minor | `0.45.0` -> `0.46.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>hashicorp/terraform-provider-tfe (tfe)</summary> ### [`v0.46.0`](https://togithub.com/hashicorp/terraform-provider-tfe/blob/HEAD/CHANGELOG.md#v0460-July-3-2023) [Compare Source](https://togithub.com/hashicorp/terraform-provider-tfe/compare/v0.45.0...v0.46.0) FEATURES: - **New Resource**: `r/tfe_agent_pool_allowed_workspaces` restricts the use of an agent pool to particular workspaces, by [@​hs26gill](https://togithub.com/hs26gill) [870](https://togithub.com/hashicorp/terraform-provider-tfe/pull/870) - `r/tfe_organization_token`: Add optional `expired_at` field to organization tokens, by [@​juliannatetreault](https://togithub.com/juliannatetreault) (#​[https://github.com/hashicorp/terraform-provider-tfe/pull/844](https://togithub.com/hashicorp/terraform-provider-tfe/pull/844)ll/844)) - `r/tfe_team_token`: Add optional `expired_at` field to team tokens, by [@​juliannatetreault](https://togithub.com/juliannatetreault) (#​[https://github.com/hashicorp/terraform-provider-tfe/pull/844](https://togithub.com/hashicorp/terraform-provider-tfe/pull/844)ll/844)) - `r/tfe_agent_pool`: Add attribute `organization_scoped` to set the scope of an agent pool, by [@​hs26gill](https://togithub.com/hs26gill) [870](https://togithub.com/hashicorp/terraform-provider-tfe/pull/870) - `d/tfe_agent_pool`: Add attribute `organization_scoped` and `allowed_workspace_ids` to retrieve agent pool scope and associated allowed workspace ids, by [@​hs26gill](https://togithub.com/hs26gill) [870](https://togithub.com/hashicorp/terraform-provider-tfe/pull/870) BUG FIXES: - `r/tfe_workspace_run`: Ensure `wait_for_run` correctly results in a fire-and-forget run when set to `false`, by [@​lucymhdavies](https://togithub.com/lucymhdavies) (#​[https://github.com/hashicorp/terraform-provider-tfe/pull/910](https://togithub.com/hashicorp/terraform-provider-tfe/pull/910)ll/910)) - `r/tfe_workspace_run`: Fix rare random run failures; adjust lists of expected run statuses to ensure that a plan is completely processed before attempting to apply it, by [@​uk1288](https://togithub.com/uk1288) (#​[https://github.com/hashicorp/terraform-provider-tfe/pull/921](https://togithub.com/hashicorp/terraform-provider-tfe/pull/921)ll/921)) - `r/tfe_notification_configuration`: Add support for missing "Check failed" Health Event notifications, by [@​lucymhdavies](https://togithub.com/lucymhdavies) (#​[https://github.com/hashicorp/terraform-provider-tfe/pull/927](https://togithub.com/hashicorp/terraform-provider-tfe/pull/927)ll/927)) - `r/tfe_registry_module`: Fix a bug that prevented users from being able to create a registry module using a github app, by [@​dsa0x](https://togithub.com/dsa0x) (#​[https://github.com/hashicorp/terraform-provider-tfe/pull/935](https://togithub.com/hashicorp/terraform-provider-tfe/pull/935)ll/935)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNTkuNCIsInVwZGF0ZWRJblZlciI6IjM1LjE1OS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: astronaut-panda[bot] <137164246+astronaut-panda[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug that prevented users from being able to create a registry module using a github app. As defined by our API docs, an organization is required for the endpoint. For gh_oauth provider, the organization is already in the context via the
tfe_oauth_client
resource, but it needs to be explicitly added when creating with github-app. The module is created in the provided organizationTesting plan
External links