Ensure that changes are applied for monorepos #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The monorepo fields were not being checked for changes, so if you ran an apply where only file triggers or trigger prefixes changed, it would not persist your data.
ghost
added
the
vancluever
approved these changes
Jun 26, 2019
thrashr888
approved these changes
Jun 26, 2019
| @@ -303,7 +303,8 @@ func resourceTFEWorkspaceUpdate(d *schema.ResourceData, meta interface{}) error | |||
| } | |||
|
|
|||
| if d.HasChange("name") || d.HasChange("auto_apply") || d.HasChange("queue_all_runs") || | |||
| d.HasChange("terraform_version") || d.HasChange("working_directory") || d.HasChange("vcs_repo") { | |||
| d.HasChange("terraform_version") || d.HasChange("working_directory") || d.HasChange("vcs_repo") || | |||
| d.HasChange("file_triggers_enabled") || d.HasChange("trigger_prefixes") { | |||
There was a problem hiding this comment.
I wonder if it makes more sense to write this check as if !d.HasChange(“ssh_key_id”)?
If this method gets called it means something changed, and the only special case seems to be the SSH key stuff.
There was a problem hiding this comment.
I think that would prevent updates to any other fields at the same time as SSH key changes, which seems incorrect.
Edit: I do agree that this condition is a footgun, but I can't think of any clear way of avoiding it, other than removing the conditional and always making the PATCH request.
There was a problem hiding this comment.
Ah yes... You are correct on that one 👍🏻I'll silence myself 😉
svanharmelen
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monorepo fields were not being checked for changes, so if you ran an apply where only file triggers or trigger prefixes changed, it would not persist your data.
Includes a test which only updates "file triggers enabled"; this test fails without the code change.