-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provider config organization, making all resource organization fields optional #762
Add provider config organization, making all resource organization fields optional #762
Conversation
c583b5b
to
91d1528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I was able to smoke test the default org 🎉
One comment, It might be helpful to indicate on the doc that when using default_organization
, the organization must already exist, unlike when an org is specified with a resource block. Consequently, the organization must be a literal and cannot be resource/datasource instance like resource.tfe_organization.test-org.name
.
721bc66
to
391446f
Compare
@Uk1288 I fixed a bug in the tfe_outputs data source and added alternative configuration using TFE_ORGANIZATION environment variable. |
391446f
to
47f8003
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Description
Drawing inspiration from the google provider, this adds a new provider config field
organization
which could make all the resource-specific organization fields optional if defined. Please review commit-wiseTesting plan
My testing methodology was making sure that config can be refactored from resource-specific org to default org with no infrastructure changes and vice-versa.
Example Config
The config contains all the resources that previously required an organization field:
External links
Closes #434