-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OPA support for policy sets #691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrinalirao
force-pushed
the
mr/TF-1451-policysets
branch
6 times, most recently
from
November 16, 2022 05:25
4a6b83f
to
86b5c96
Compare
mrinalirao
force-pushed
the
mr/TF-1451-policysets
branch
from
November 16, 2022 05:33
86b5c96
to
6c01d22
Compare
glennsarti
reviewed
Nov 17, 2022
glennsarti
approved these changes
Nov 17, 2022
glennsarti
approved these changes
Nov 17, 2022
brandonc
requested changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found just the one issue with overridable.
# Conflicts: # go.mod # go.sum
Added an acceptance test for setting overridable:
|
brandonc
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add OPA support to the tfe-provider for policy sets. OPA is still in beta phase.
The existing tfe_policy_set provider will allow for creation of both sentinel as well as OPA policies in the provider.
This is the second of the 3 PRs for adding OPA support:
Previous PRs: #690
Upcoming PRs
Testing plan
Acceptance tests added
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
$ TESTARGS="-run TestAccTFEPolicySetOPA_basic" envchain staging make testacc
$ TESTARGS="-run TestAccTFEPolicySetDataSourceOPA_basic" envchain staging make testacc