Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OPA support to the provider for Policies #690
Add OPA support to the provider for Policies #690
Changes from 8 commits
a18da5d
dec3e79
84363be
063b4fc
d9b772a
9a5f55a
7233c34
1938564
6e8a5a1
972d5a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this field is truly optional. I got this error when omitting it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 👍 Turns out the api docs around
data.attributes.enforce[].mode
are wrong. The enforce_mode isrequired
in Atlas.I have made changes to add defaults if the enforce mode is not provided.
Since the
tfe_sentinel_policy
provider sets the enforce_mode as optional, I have done the same fortfe_policy
, so our customers dont have to care about the enforce_mode when they switch fromtfe_sentinel_policy
totfe_policy
and the experience is the same.Meanwhile I am going to go fix the API docs :)