[#TF-720] Add allow_force_delete_workspaces organization setting to the tfe provider

[emlanctot]

Description

This change adds the allow_force_delete_workspaces setting to the TFE provider.

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

• Related PR

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See TESTS.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

/opt/homebrew/Cellar/go/1.19.2/libexec/bin/go tool test2json -t /private/var/folders/2z/33zp571x44v_ndv_hk8cyy1w0000gp/T/GoLand/___1TestAccTFEOrganization_basic_in_github_com_hashicorp_terraform_provider_tfe_tfe.test -test.v -test.paniconexit0 -test.run ^\QTestAccTFEOrganization_basic\E$
=== RUN   TestAccTFEOrganization_basic
--- PASS: TestAccTFEOrganization_basic (8.08s)
PASS

Process finished with the exit code 0



/opt/homebrew/Cellar/go/1.19.2/libexec/bin/go tool test2json -t /private/var/folders/2z/33zp571x44v_ndv_hk8cyy1w0000gp/T/GoLand/___1TestAccTFEOrganization_full_in_github_com_hashicorp_terraform_provider_tfe_tfe.test -test.v -test.paniconexit0 -test.run ^\QTestAccTFEOrganization_full\E$
=== RUN   TestAccTFEOrganization_full
--- PASS: TestAccTFEOrganization_full (7.31s)
PASS

Process finished with the exit code 0

[hashicorp-cla]

All committers have signed the CLA.

[JarrettSpiker]

Looks good to me!

We will just need to wait until the go-tfe changes are merged and released, and update this to point at the released version!

[JarrettSpiker]

Looks good to me! I don't know that I have approval permissions on this repo, though, let's see...

[brandonc]

Code review. Smoke test forthcoming

[brandonc]

Since the API produces the default value, you may want to remove Default and set Computed to true. My understanding of Default is that we use it when we want the provider to set a state value, perhaps to backfill a new required field? I'm going to smoke test both cases, but the other settings in this schema seem to rely on the API defaults so it would be strange to have a new argument with slightly different behavior.

[brandonc]

OK so I tested 3 scenarios and found some interesting behavior differences:

1. Optional: true, Default: false did not show the field in the plan but stored false in state
2. Optional: true, Computed: true showed the field in the plan as (known after apply) and stored false in state.
3. Optional: true with no other options had the same behavior as Optional: true, Default: false

I expected something different!