-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add datasource for policy_set #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Uk1288, I was able to successfully reproduce this! ✅
I would recommend expanding your testing plan. Like in this case, a tester will not be able to successfully replicate the behavior without the following: a
, b
, c
. And then add those to your testing plan. 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
) | ||
|
||
func TestAccTFEPolicySetDataSource_basic(t *testing.T) { | ||
skipIfFreeOnly(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
func TestAccTFEPolicySetDataSource_notFound(t *testing.T) { | ||
skipIfFreeOnly(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this since the API returns a 404 if the policy set is not found or the user is not authorized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per discussed, this will be added on next PR.
I have updated the test plan to indicate that policy sets is a paid plan. I am not sure what the comment: |
Description
Add datasource for policy set. This PR is in relation to the
tfe_workspace_policy_set
work here #591Remember to:
Update the Change Log
Update the Documentation
Testing plan
Note: Policy set is a paid plan.
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See TESTS.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.