Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to prevent unnecessary tfe_registry_modules replacement #572

Merged

Conversation

Uk1288
Copy link
Contributor

@Uk1288 Uk1288 commented Jul 27, 2022

Description

Describe why you're making this change.
After a registry module is created and consecutive apply is run, the registry modules get recreated even though there is no change in the params. This PR adds changes to prevent unnecessary tfe_registry_modules replacement.

Remember to:

Testing plan

  1. Create config with resource "tfe_registry_module"
  2. Run an apply, it should be successful
  3. Run another apply. Before this PR, new changes will be applied even though the params did not change
  4. After this PR, no changes should be applied unless the params change.

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See TESTS.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFERegistryModule" make testacc

...

@Uk1288 Uk1288 requested a review from a team as a code owner July 27, 2022 16:59
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix the issue. Sorry I suggested the change in the first place! 🙃 Can you add a CHANGELOG note? The next release will be 0.35.0

@brandonc brandonc linked an issue Jul 27, 2022 that may be closed by this pull request
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Brandon Croft <brandon.croft@gmail.com>
@brandonc brandonc merged commit 05f353a into main Jul 27, 2022
@brandonc brandonc deleted the uk1288-prevent-unnecessary-tfe_registry_modules-replacement branch July 27, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfe_registry_modules with VCS connection get replaced on every run
2 participants