-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow agent pools to be imported by name #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note about a case that may or may not deserve some additional handling, other than that this looks great! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 ! Minor grammatical error and a non blocker below ⬇️
Co-authored-by: Sebastian Rivera <sebastian.rivera@hashicorp.com>
d3ddfa1
to
d799069
Compare
Co-authored-by: Sebastian Rivera <sebastian.rivera@hashicorp.com>
d799069
to
9790800
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and it worked!
Description
Allow agent pools to be imported by
org name/agent pool name
Testing plan
External links
Output from acceptance tests