Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default for file_triggers_enabled to false #510

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Change default for file_triggers_enabled to false #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce87350
Change default for `file_triggers_enabled` to false
matejrisek Jun 2, 2022
910d5df
Add changelog entry
matejrisek Jun 3, 2022
2020546
Address PR comments
matejrisek Jun 3, 2022
21d20d4
Update provider documentation
matejrisek Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ BUG FIXES:
FEATURES:
* r/team, d/team: Add manage_run_tasks to the tfe_team organization_access attributes ([#486](https://github.com/hashicorp/terraform-provider-tfe/pull/486))

BREAKING CHANGES:
* r/tfe_workspace: Default value of the `file_triggers_enabled` field is changed to `false`. This will align the
`file_triggers_enabled` field default value with the default value for the same field in the
[TFC API](https://www.terraform.io/cloud-docs/api-docs/workspaces).
If the value of the `file_triggers_enabled` field was not explicitly set and either of the fields `working_directory`
(not an empty string) or `trigger_prefixes` was used - to keep the behavior unchanged, the `file_trigger_enabled`
field should now explicitly be set to `true`. ([#510](https://github.com/hashicorp/terraform-provider-tfe/pull/510/files))

## 0.31.0 (April 21, 2022)

BUG FIXES:
Expand Down
2 changes: 1 addition & 1 deletion tfe/resource_tfe_workspace_migrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func resourceTfeWorkspaceResourceV0() *schema.Resource {
"file_triggers_enabled": {
Type: schema.TypeBool,
Optional: true,
Default: true,
Default: false,
},

"operations": {
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/workspace.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ The following arguments are supported:
for state storage only. This value _must not_ be provided if `operations`
is provided.
* `file_triggers_enabled` - (Optional) Whether to filter runs based on the changed files
in a VCS push. Defaults to `true`. If enabled, the working directory and
in a VCS push. Defaults to `false`. If enabled, the working directory and
trigger prefixes describe a set of paths which must contain changes for a
VCS push to trigger a run. If disabled, any push will trigger a run.
* `global_remote_state` - (Optional) Whether the workspace allows all workspaces in the organization to access its state data during runs. If false, then only specifically approved workspaces can access its state (`remote_state_consumer_ids`).
Expand Down