-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add run_tasks permission to Team Access #487
Conversation
This is a breaking change because custom access permissions will require the run_tasks parameter e.g.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, missing the provider documentation + Wondering how our docs should reflect this breaking change? Would a simple -> **Note**
suffice?
Run Tasks has added a new `run_tasks` custom permission to Team Workspace access. This commit adds this new permission to the Team Access object (both resource and data) and adds acceptance tests for both objects.
50a77fc
to
4bc5ff4
Compare
@sebasslash I've updated the docs and changelog. I have no idea how to surface the breaking changen-ess besides bumping a major version number. |
@glennsarti I think we reserve the right to break the API in reasonable ways until release 1.0. The best thing to do is just note it in CHANGELOG, as you've done. I've already forgotten why we couldn't default this setting, but I'm wondering how to avoid similar breaking changes after 1.0... |
For ref - Private chat about why it is - https://hashicorp.slack.com/archives/C01BR9FR8KZ/p1651525482312299
|
@sebasslash Re-requesting a review based on the changes I made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebasslash is out of the office but I think we are good to go. Thanks for adding context about the required permission arguments!
Description
Run Tasks has added a new
run_tasks
custom permission to TeamWorkspace access. This commit adds this new permission to the
Team Access object (both resource and data) and adds acceptance
tests for both objects.
Testing plan
N/A Added acceptance tests
External links
Output from acceptance tests
N/A It'll be in the CI tests