Add sso_team_id to the tfe_team resource and data source #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarrettSpiker
changed the title
mpminardi
reviewed
Apr 12, 2022
| if v, ok := d.GetOk("sso_team_id"); ok { | ||
| options.SSOTeamID = tfe.String(v.(string)) | ||
| } else { | ||
| options.SSOTeamID = tfe.String("") |
There was a problem hiding this comment.
This is the else case you mentioned that can be removed once this PR is through right? (This is more just out of my own curiosity / to reload context and not at all blocking).
There was a problem hiding this comment.
yah, that is right
mpminardi
reviewed
Apr 12, 2022
website/docs/r/team.html.markdown
Outdated
| @@ -41,6 +41,7 @@ The following arguments are supported: | |||
| * `organization` - (Required) Name of the organization. | |||
| * `visibility` - (Optional) The visibility of the team ("secret" or "organization"). Defaults to "secret". | |||
| * `organization_access` - (Optional) Settings for the team's [organization access](https://www.terraform.io/docs/cloud/users-teams-organizations/permissions.html#organization-level-permissions). | |||
| * `sso_team_id` - (Optional) Unique Identifier to control team membership via SAML. Defaults to `null` | |||
There was a problem hiding this comment.
It looks like we link to the docs for the organization_access attribute above. Should we be doing the same for the SSO team ID docs here and in the datasource docs?
There was a problem hiding this comment.
Yah, good idea, updated
mpminardi
approved these changes
Apr 12, 2022
JarrettSpiker
force-pushed
the
SsoTeamId
branch
from
d98a204
to
e2f5542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add sso_team_id to the tfe_team resource and data source
Testing plan
Output from acceptance tests