Fix paginated remote state consumers #367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #366
Description
Previously, any number of remote state consumers over a standard page (20 results) would cause a subsequent plan to try and continue adding the list of consumer IDs indefinitely, as the Read implementation didn't take pagination in to account.
I also bumped the page size for these requests to the maximum (100), as for large Terraform Enterprise installations it could be relatively common to map out hundreds of workspaces as consumers of one.
Testing plan
Create a configuration that adds several remote state consumers to a single workspace. The subsequent plan should be empty, and not look like the following failing test case demonstrating the problem: