-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#TF-15257] add manage-agent-pools to team organization access #1358
Conversation
a55118c
to
3a0b808
Compare
3a0b808
to
48c8b7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, however, I found two things that could use some fixing, and left suggestions for both! ⭐
CHANGELOG.md
Outdated
## v0.56.0 | ||
|
||
FEATURES: | ||
* `r/tfe_team`: Add attribute `manage_agent_pools` to `organization_access` on `tfe_team` by @emlanctot [#1358](https://github.com/hashicorp/terraform-provider-tfe/pull/1358) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this needs to be moved in the unreleased section, as v0.56.0
looks like the latest release!
website/docs/r/team.html.markdown
Outdated
@@ -58,6 +58,7 @@ The `organization_access` block supports: | |||
* `manage_teams` - (Optional) Allow members to create, update, and delete teams. | |||
* `manage_organization_access` - (Optional) Allow members to update the organization access settings of teams. | |||
* `access_secret_teams` - (Optional) Allow members access to secret teams up to the level of permissions granted by their team permissions setting. | |||
* `manage_secret_teams` - (Optional) Allows members to create, edit, and delete agent pools within their organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I believe that manage_agent_pools
is what we're looking for here 😊 :
* `manage_secret_teams` - (Optional) Allows members to create, edit, and delete agent pools within their organization. | |
* `manage_agent_pools` - (Optional) Allows members to create, edit, and delete agent pools within their organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg
a6b4733
to
ad38813
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for updating the changelog and team documentation! I noticed one more (this time non-blocking!) thing (sorry!) and left a suggestion for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I echo Julianna's minor nitpick.
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Description
This PR adds support that will allow the manage_agent_pools organization access setting to be set on teams via the provider.
Remember to:
Testing plan
manage_agent_pools
should default to false for new teams.manage_agent_pools
is omitted, they should default to false.manage_agent_pools
should be able to be set or unset via the provider.External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.