Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ignore_additional_tag_names to tfe_workspace resource #1254

Merged

Conversation

brandonc
Copy link
Collaborator

Description

A boolean value that, when set to true, allows additional unmanaged tags to be applied to this workspace outside of terraform without being overwritten by tag_names config. This creates exceptional behavior in terraform with respect to tag_names and is generally not recommended. But given that the alternative is to ignore all updates to tags after they are created, or not be able to mix unmanaged and managed tags at all, it seems like a reasonable feature until we separate the tag resource altogether

Copy link
Contributor

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
website/docs/r/workspace.html.markdown Outdated Show resolved Hide resolved
internal/provider/resource_tfe_workspace.go Show resolved Hide resolved
brandonc and others added 2 commits February 26, 2024 11:16
A boolean value that, when set to true, allows additional unmanaged
tags to be applied to this workspace outside of terraform without
being overwritten by `tag_names` config. This creates exceptional
behavior in terraform with respect to `tag_names` and is generally not
recommended.

Co-authored-by: mbillow <marc@billow.me>
@brandonc brandonc force-pushed the TF-13152-hashicorp-tfe-allow-unmanaged-workspace-tag-names branch from 86f5ea7 to 5e8cbdb Compare February 26, 2024 18:16
@brandonc brandonc merged commit 2b1f823 into main Feb 26, 2024
9 checks passed
@brandonc brandonc deleted the TF-13152-hashicorp-tfe-allow-unmanaged-workspace-tag-names branch February 26, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants